Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): remove version check of resty.events #162

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

bungle
Copy link
Member

@bungle bungle commented Jun 19, 2024

Summary

lua-resty-events is still in active development, we should support more possible versions.

KAG-4760

@bungle bungle force-pushed the feat/support_resty_events_03x branch from ec1614e to 580ae05 Compare June 19, 2024 17:08
gszr
gszr previously approved these changes Jun 19, 2024
@bungle bungle force-pushed the feat/support_resty_events_03x branch from 580ae05 to 2375c2c Compare June 19, 2024 17:09
@bungle bungle changed the title feat(lib): support lua-resty-events 0.3.x feat(lib): remove stupid version check from resty.events Jun 19, 2024
gszr
gszr previously approved these changes Jun 19, 2024
@bungle bungle changed the title feat(lib): remove stupid version check from resty.events feat(lib): remove stupid version check of resty.events Jun 19, 2024
@bungle bungle force-pushed the feat/support_resty_events_03x branch from 2375c2c to 96342f3 Compare June 19, 2024 17:24
@bungle bungle changed the title feat(lib): remove stupid version check of resty.events feat(lib): remove version check of resty.events Jun 19, 2024
@bungle bungle force-pushed the feat/support_resty_events_03x branch from 96342f3 to dbdce63 Compare June 19, 2024 17:34
gszr
gszr previously approved these changes Jun 19, 2024
@bungle bungle force-pushed the feat/support_resty_events_03x branch 2 times, most recently from b8434b4 to 554406d Compare June 19, 2024 17:57
gszr
gszr previously approved these changes Jun 19, 2024
Copy link
Contributor

@locao locao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, but wouldn't it be better if we improved the cache key instead of removing the cache at all?

.github/workflows/build_and_test_with_resty_events.yml Outdated Show resolved Hide resolved
@bungle
Copy link
Member Author

bungle commented Jun 19, 2024

The changes LGTM, but wouldn't it be better if we improved the cache key instead of removing the cache at all?

Perhaps with time. My conclusion is that we have lost more time to caching issues that it has ever given time back. There is always a case that someone who turns on caches doesn't seem to think about. Caching is totally unneeded on low traffic repo like this. Where full anything takes just minutes.

@bungle bungle merged commit 3da3591 into master Jun 19, 2024
7 checks passed
@bungle bungle deleted the feat/support_resty_events_03x branch June 19, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants