fix(timers) prevent exhausting timers in init/worker_init #57

Tieske · 2020-09-20T12:46:39Z

fixes #40

Renamed the lock for code clarity as well.

### Summary * BREAKING: fallback for deprecated top-level field `type` is now removed (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56) * BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes a lot of the APIs in this library asynchronous as the worker events `post` and `post_local` won't anymore call `poll` on a running worker automatically, for more information, see: https://github.com/Kong/lua-resty-worker-events#200-16-september-2020 * BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures are also set to 0) [#55](Kong/lua-resty-healthcheck#55) * feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49) * fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29) * fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48) * fix: makefile; make install * feature: added a status version field [#54](Kong/lua-resty-healthcheck#54) * feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54) * fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47) * fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44) * fix: replace timer and node-wide locks with resty-timer, to prevent interval skips [#59](Kong/lua-resty-healthcheck#59) * change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25) * fix: do not run out of timers during init/init_worker when adding a vast amount of targets [#57](Kong/lua-resty-healthcheck#57) * fix: do not call on the module table, but use a method for locks. Also in [#57](Kong/lua-resty-healthcheck#57)

Renamed the lock for code clarity as well.

Tieske self-assigned this Sep 20, 2020

Tieske marked this pull request as draft September 20, 2020 12:46

Tieske force-pushed the timers branch 2 times, most recently from 0b044d6 to 51f47a8 Compare September 22, 2020 12:16

Tieske marked this pull request as ready for review September 22, 2020 12:22

Tieske force-pushed the timers branch 2 times, most recently from 728c52c to ad47cc1 Compare September 22, 2020 12:36

Tieske added 2 commits September 22, 2020 14:40

fix(timers) prevent exhausting timers in init/worker_init (#57)

3f63633

fix(lock) do not call resty_lock.lock but use instance method (#57)

5d5d4fb

Renamed the lock for code clarity as well.

Tieske force-pushed the timers branch from ad47cc1 to 5d5d4fb Compare September 22, 2020 12:41

Tieske merged commit 4f3c3d1 into master Sep 22, 2020

Tieske added a commit that referenced this pull request Sep 22, 2020

fix(timers) prevent exhausting timers in init/worker_init (#57)

d0d53a5

Tieske deleted the timers branch September 22, 2020 12:41

bungle mentioned this pull request Sep 22, 2020

chore(deps) bump worker events and healthchecks Kong/kong#6361

Closed

Sn0rt mentioned this pull request Apr 21, 2023

interval between health checks is incorrect apache/apisix#9327

Closed

AlinsRan pushed a commit to AlinsRan/lua-resty-healthcheck that referenced this pull request Jun 2, 2023

fix(timers) prevent exhausting timers in init/worker_init (Kong#57)

45b37af

AlinsRan pushed a commit to AlinsRan/lua-resty-healthcheck that referenced this pull request Jun 2, 2023

fix(lock) do not call resty_lock.lock but use instance method (Kong#57)

bb5a3e1

Renamed the lock for code clarity as well.

AlinsRan mentioned this pull request Jun 6, 2023

chore: update healcheck dependency apache/apisix#9590

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(timers) prevent exhausting timers in init/worker_init #57

fix(timers) prevent exhausting timers in init/worker_init #57

Tieske commented Sep 20, 2020 •

edited

Loading

fix(timers) prevent exhausting timers in init/worker_init #57

fix(timers) prevent exhausting timers in init/worker_init #57

Conversation

Tieske commented Sep 20, 2020 • edited Loading

Tieske commented Sep 20, 2020 •

edited

Loading