Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): kongponents alpha phase 4 [KHCP-10182] #1069

Merged
merged 25 commits into from
Jan 17, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Jan 11, 2024

Summary

Jira: https://konghq.atlassian.net/browse/KHCP-10182

Phase 4 adoption of components reskinned in alpha version of Kongponents v9 release. Includes these components:

  • KSelect
  • KMultiselect
  • KTabs
  • KCopy (unused)

Resources

@portikM portikM self-assigned this Jan 11, 2024
@portikM portikM marked this pull request as ready for review January 16, 2024 15:35
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested and LGTM🚀

@Leopoldthecoder
Copy link
Member

Leopoldthecoder commented Jan 17, 2024

nit: the upstream form in this PR has HTTP statuses displayed as badges. Should we keep them collapsed as before?

This PR Before
image image

Edit: this also applies to AddToGroupModal.vue and AddConsumerModal.vue.

Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamdehaven adamdehaven merged commit 8dc4cb0 into main Jan 17, 2024
30 checks passed
@adamdehaven adamdehaven deleted the fix/public-ui-kongponents-phase-4 branch January 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants