fix(entities-plugins): prevent infinite updates for dev #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamdehaven
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KM-532
This PR introduces a check for changes to the
srcattribute, which should prevent the infinite update issue.Currently, we are directly updating the
srcattribute of the<img>element within the@errorhandler. If thedefaultIconis invalid, this can result in an infinite update loop.Additionally, due to a bug in Vite, even though the
new URL(...)part is correctly transformed into base64 data URIs, when developing a project that depends onpublic-ui-components, Vite reprocesses the asset URL, leading to an invalid URL in the development environment. Combined with the original implementation of<PluginIcon>, this causes an infinite update loop during host app development (e.g.,konnect-ui-apps).I’ve also submitted a PR to address the issue in Vite itself, but since we are still using
vite@4.5.3inkonnect-ui-apps, we may need this temporary fix in the meantime.