Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Attempt to trigger flaky test #712

Closed
wants to merge 2 commits into from
Closed

Draft: Attempt to trigger flaky test #712

wants to merge 2 commits into from

Conversation

nekolab
Copy link
Contributor

@nekolab nekolab commented Aug 17, 2023

Summary

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@nekolab nekolab force-pushed the tests/fix-flaky-upstreams-form branch 3 times, most recently from a62de5d to b924a4b Compare August 17, 2023 09:48
@nekolab
test(entities-upstreams-targets): fix flaky tests and test results up…
188598d 
…load workflow

The `cy.wait()` will wait intercepted network events for 5 seconds
by default. But in the CI environment, the
`['@getupstream', '@fetchservices', '@fetchCertificates']`
combination will took more than 4 seconds so the test will be flaky
if it occasionally execeeds the 5 seconds limitation.

The slow part seems caused by the Cypress's vm hooks. It does not
affect the component in development/production mode. So it's safe
to loose the timeout to 10 seconds

This commit also fix the test results upload failure. The artifact
name could not contains some special characters like `/`, which
will occur in `matrix.container`. A new step is added to normalize
the artifact name to make sure it can be uploaded successfully.
@nekolab
test: test
c0cad1d
@nekolab nekolab force-pushed the tests/fix-flaky-upstreams-form branch from d6b73d8 to c0cad1d Compare August 17, 2023 16:53
@nekolab nekolab closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven will be requested when the pull request is marked ready for review adamdehaven is a code owner

@ValeryG ValeryG Awaiting requested review from ValeryG ValeryG will be requested when the pull request is marked ready for review ValeryG is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom will be requested when the pull request is marked ready for review jillztom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nekolab