3주차 미션 / 서버 3조 장현준 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 쿼리 파싱 함수 리팩토링 2. 로그인 함수 리팩토링
JangIkhwan
reviewed
Oct 7, 2024
Comment on lines
+39
to
+43
| public void setCookie(boolean isLogin) throws IOException { | ||
| if(isLogin){ | ||
| final String LOGIN_TRUE = "logined=true"; | ||
| dos.write((SET_COOKIE.getHeader()+ COLON + LOGIN_TRUE + CRLF).getBytes()); | ||
| } |
There was a problem hiding this comment.
로그인 했는지 확인하는 것은 컨트롤러에서 체크하는 것이 좋을 것 같습니다. httpResponseHeader 객체는 값을 쓰는 역할만 하고, 값을 써야하는지 판단하는 건 컨트롤러에서 맡는 거죠
Comment on lines
+44
to
+48
| public void setCss(String css) throws IOException { | ||
| body = Files.readAllBytes(Paths.get(ROOT.getUrl() + css)); | ||
| response200(body.length, CSS); | ||
| responseBody(); | ||
| } |
There was a problem hiding this comment.
forward() 기능과 큰 차이가 없는 것 같아요. forward()에서 확장자가 html인지 css인지 확인해서 알맞은 content-type이 응답메시지에 담기도록 수정해보면 어떨까요? 알맞은 컨트롤러가 없으면 forward()를 호출하니까 css를 처리할 수 있겠죠?
Comment on lines
+29
to
+32
| private static User findUser(Map<String, String> loginInfo) { | ||
| MemoryUserRepository memoryUserRepository = MemoryUserRepository.getInstance(); | ||
| return memoryUserRepository.findUserById(loginInfo.get(USER_ID.getKey())); | ||
| } |
There was a problem hiding this comment.
repository 객체를 생성자 주입으로 받아서 사용해보는 건 어떨까요?
Comment on lines
+11
to
+12
| private final int requestContentLength; | ||
| private final boolean LoginStatus; |
There was a problem hiding this comment.
헤더에는 여러 가지 정보가 들어가죠. 미션에서는 쿠키의 로그인 상태만 보려고 했지만, 좀 더 다양한 상황을 처리하려면 헤더의 모든 키와 값을 Map에 저장하는 것이 좋은 방법이 될 것 같아요.
| controllers.put(URL.SIGNUP.getUrl(), new SignUpController()); | ||
| controllers.put(URL.LOGIN.getUrl(), new LoginController()); | ||
| controllers.put(URL.USER_LIST.getUrl(), new UserListController()); | ||
| controllers.put(URL.CSS.getUrl(), new CssController()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.