3주차 미션 / 서버 3조 김윤서 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangIkhwan
reviewed
Oct 7, 2024
| String body = IOUtils.readData(br, contentLength); | ||
| Map<String, String> queryParameter = HttpRequestUtils.parseQueryParameter(body); | ||
|
|
||
| User user = createUserFromQuery(queryParameter); |
There was a problem hiding this comment.
유저 객체를 생성하는 건 이 객체의 역할에 맞지는 않는 것 같네요. 그냥 생성자를 쓰셔도 될 것 같아요
Comment on lines
+223
to
+232
| private void handleCssResponse(DataOutputStream dos, String requestPath) { | ||
| String filePath = WEB_ROOT + requestPath; | ||
| byte[] body = readFile(filePath); | ||
| if (body != null) { | ||
| response200CssHeader(dos, body.length); | ||
| responseBody(dos, body); | ||
| } else { | ||
| log.log(Level.SEVERE, "CSS file not found: " + requestPath); | ||
| } | ||
| } |
There was a problem hiding this comment.
handleFileResponse 메소드에서 css를 처리할 수 있지 않을까요? 확장자가 .css인지 확인해서 헤더에 들어갈 content type을 바꾸는 식으로 말이죠.
Comment on lines
+264
to
+273
| private void response302WithCookieHeader(DataOutputStream dos, String location, String cookie) { | ||
| try { | ||
| dos.writeBytes("HTTP/1.1 302 Found \r\n"); | ||
| dos.writeBytes("Location: " + location + "\r\n"); | ||
| dos.writeBytes("Set-Cookie: " + cookie + "\r\n"); | ||
| dos.writeBytes("\r\n"); | ||
| } catch (IOException e) { | ||
| log.log(Level.SEVERE, e.getMessage()); | ||
| } | ||
| } |
There was a problem hiding this comment.
쿠키가 추가되어야 하니 새로운 메소드를 만들었군요. 그런데 헤더의 값들을 Map 컬렉션으로 관리한다면 어떨까요? 그러면 쿠키를 추가해야한다면, Map에 Set-cookie을 추가하면 되겠죠! 그러면 좀 더 유연한 헤더 작성이 가능하지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
아직 리팩이 많이 부족한 코드입니다 ..
빠른 시일 내에 추가 보완하겠습니다