3주차 미션 / 서버 3조 이윤희 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangIkhwan
reviewed
Oct 7, 2024
| public class HomeController implements Controller { | ||
| @Override | ||
| public void execute(HttpRequest request, HttpResponse response) throws Exception { | ||
| response.forward("/index.html"); |
There was a problem hiding this comment.
url을 enum으로 관리하니까 enum을 사용하는 게 어떨까요?
| import static enumClass.UserQueryKey.*; | ||
|
|
||
| public class LoginController implements Controller { | ||
| private final Repository repository = MemoryUserRepository.getInstance(); |
There was a problem hiding this comment.
필드 주입보다는 생성자 주입을 더 권하고 싶어요. 필드 주입을 사용하면 다른 repository 객체로 바꿀 때 이 부분을 수정해야하거든요
|
|
||
| @Override | ||
| public void execute(HttpRequest request, HttpResponse response) throws Exception { | ||
| Map<String, String> params = request.getBody() != null ? HttpRequestUtils.parseQueryParameter(request.getBody()) : null; |
There was a problem hiding this comment.
파라미터를 파싱하는 부분은 httpRequest에서 처리해보는 건 어떨까요?
| this.body = body; | ||
| } | ||
|
|
||
| public static HttpRequest from(BufferedReader br) throws IOException { |
There was a problem hiding this comment.
생성자와 팩토리 메소드의 작업이 명확히 나뉜 점 좋은 것 같아요. 그런데 httpRequest 객체의 책임이 커져서 팩토리 메소드의 길이가 길어지는 것 같아 보여요. httpRequest객체에서 구성을 이용해서 startline, header 객체를 갖도록 해보면 어떨까요? 그러면 책임을 잘 분산할 수 있지 않을까요?
| public void forward(String path) throws IOException { | ||
| byte[] body = Files.readAllBytes(Paths.get("webapp" + path)); | ||
| dos.writeBytes("HTTP/1.1 " + OK.getValue() + "\r\n"); | ||
| dos.writeBytes(CONTENT_TYPE.getValue() + ": text/html;charset=utf-8\r\n"); |
JangIkhwan
reviewed
Oct 7, 2024
| if (params != null) { | ||
| User user = repository.findUserById(params.get(USERID.getValue())); | ||
| if (user != null && user.getPassword().equals(params.get(PASSWORD.getValue()))) { | ||
| response.redirect(INDEX_PAGE.getValue()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.