Skip to content

Commit

Permalink
disable flaky test, lint
Browse files Browse the repository at this point in the history
  • Loading branch information
KonradIT committed Sep 4, 2024
1 parent 38fc5bc commit 9773f81
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion pkg/dji/dji.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ func (Entrypoint) Import(params utils.ImportParams) (*utils.Result, error) {
return nil
},
})

if err != nil {
inlineCounter.SetFailure(err, "")
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/gopro/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import (

const parent = "gopro"

func gpsMinAccuracyFromConfig() uint16 {
func gpsMinAccuracyFromConfig() uint {
key := fmt.Sprintf("%s.gps_accuracy", parent)
viper.SetDefault(key, 500)
return uint16(viper.GetUint(key))
return viper.GetUint(key)
}

func gpsMaxAltitudeFromConfig() float64 {
Expand Down
2 changes: 0 additions & 2 deletions pkg/gopro/gopro.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ folderLoop:
},
Unsorted: true,
})

if err != nil {
inlineCounter.SetFailure(err, "")
}
Expand Down Expand Up @@ -510,7 +509,6 @@ func importFromGoProV1(params utils.ImportParams) utils.Result {
},
Unsorted: true,
})

if err != nil {
inlineCounter.SetFailure(err, "")
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/gopro/location.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ GetLocation:

telems := lastEvent.ShitJson()
for _, telem := range telems {
if telem.Altitude > gpsMaxAltitudeFromConfig() || telem.Latitude == 0 || telem.Longitude == 0 || telem.GpsAccuracy > gpsMinAccuracyFromConfig() {
if telem.Altitude > gpsMaxAltitudeFromConfig() || telem.Latitude == 0 || telem.Longitude == 0 || uint(telem.GpsAccuracy) > gpsMinAccuracyFromConfig() {
continue
}

Expand Down
1 change: 0 additions & 1 deletion pkg/insta360/insta360.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ func (Entrypoint) Import(params utils.ImportParams) (*utils.Result, error) {
return nil
},
})

if err != nil {
inlineCounter.SetFailure(err, "")
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/utils/reversegeo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ type pair struct {
}

func TestPrettyAddress(t *testing.T) {
t.Skip("Flaky test")

expected := []pair{
{
Address: Location{
Expand Down

0 comments on commit 9773f81

Please sign in to comment.