Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply the mtime given by the gopro to the written files #126

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

klaernie
Copy link
Contributor

@klaernie klaernie commented Feb 6, 2024

set the mtime of downloaded files

The gopro already tells us what the mtime of the files should be, so we should set the mtime of our newly mades copies to the respective timestamp.

This allows applications like Google Photos to have the actual timestamp available, when the file was written, instead of reading the timestamp when the files were downloaded from the camera.

Please be aware that this is the first time I'm ever handling golang code, so if any of this is not acceptable or not in proper style please tell me - I'm currently in the "I know barely enough to be dangerous" phase. ;)

Type:

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Camera:

  • GoPro
  • Insta360
  • DJI
  • Android
  • This PR adds a new camera

Component:

  • Core logic
  • Import
  • Merging
  • Firmware Update
  • Video Manipulation

Checklist before approval:

  • Linter pass
  • Build pass

@klaernie
Copy link
Contributor Author

klaernie commented Feb 6, 2024

FYI: in my branch the linter complains, but the errors are unrelated to the changes introduced, and are identical to the ones currently present in the development branch.

@klaernie
Copy link
Contributor Author

klaernie commented Feb 6, 2024

oh, spoke too soon, seems my use of the .tmp string crossed a threshold - or at least that's what I understand from it

This allows applications like Google Photos to have the actual timestamp
available, when the file was written, instead of reading the timestamp
when the files were downloaded from the camera.
@KonradIT KonradIT merged commit 3b595fe into KonradIT:development Sep 4, 2024
3 checks passed
@klaernie klaernie deleted the http-mtime branch September 6, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants