Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make HTTP retry when the GoPro is overwhelmed #128

Merged
merged 2 commits into from
Sep 7, 2024

Commits on Sep 4, 2024

  1. switch to retryablehttp to allow downloading many files

    My HERO12 did not like being asked for more than about 5-7 files
    simultaneously, but dropped some of the /gp/gpMediaMetadata with a
    timeout. So after the files where the call to gpMediaMetadata was
    successfull were downloaded, I got presented with a bunch of errors
    where it didn't work, and of cause the files were not downloaded.
    
    Switching to a retrying approach means that we still hammer the GoPro
    for the first couple seconds, but allow the requests to proceed later.
    
    Some of this is still WIP - the config file has a timeout option, that I
    dropped since I do not understand enough go to incorporate it, yet.
    klaernie authored and KonradIT committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    eac3e24 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    f95de84 View commit details
    Browse the repository at this point in the history