use partition.Mountpoint instead of .Device #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Windows both properties carry the same value, yet under Linux .Device is the name of the block device like /dev/sdc1 and mountpoint is the place in the filesystem where this device is mounted and where one can access the data in it - like /mnt/insta-sdcard. Hence when trying to access files like MISC/version.txt, DCIM/fileinfo_list.list or MISC/GIS/dji.gis it will not work. Switching to .Mountpoint means file access under Linux will start to work, and keep working under Windows.
|
Thanks, I'll apply this PR without passing linter / tests and then fix it myself afterwards. |
|
Cool! Thanks for merging! Once you've fixed the linter and test I'd happily rebase my other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use partition.Mountpoint instead of .Device
Under Windows both properties carry the same value, yet under Linux .Device is the name of the block device like /dev/sdc1 and mountpoint is the place in the filesystem where this device is mounted and where one can access the data in it - like /mnt/insta-sdcard.
Hence when trying to access files like MISC/version.txt, DCIM/fileinfo_list.list or MISC/GIS/dji.gis it will not work.
Switching to .Mountpoint means file access under Linux will start to work, and keep working under Windows.
Type:
Camera:
Component:
Checklist before approval: