make GetFlagString() process the default string #133
Merged
+22
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the dateFormat / --date has a default set to dd-mm-yyy, the GetFlagString() function does not ever attempt reading the value from the config file. Now every GetFlagString() invocation explicitly lists the default values, like GetFlagInt() does, hence one can override the date format in the config file.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR here: #127
make GetFlagString() process the default value, not Cobra
since the dateFormat / --date has a default set to dd-mm-yyy, the GetFlagString() function does not ever attempt reading the value from the config file.
Now every GetFlagString() invocation explicitly lists the default values, like GetFlagInt() does, hence one can set the date format in the config file.
Type:
Camera:
Component:
Checklist before approval: