Info command to print GoPro settings #86
Conversation
|
Hi @daktak , for that issue I had more in mind to read a video file and output the protune info and other stuff, kinda like what its being done here: https://gopro.github.io/labs/control/metadata/ But printing it nicely in the terminal. This is also cool, but not what the issue is about. |
|
Oh cool, maybe can switch between this and reading file by "sd_card" or "connect" |
| func GetInfo(in string) (CameraStatus, error) { | ||
| var gpStatus = &CameraStatus{} | ||
| err := caller(in, "gp/gpControl/status", gpStatus) | ||
| if err != nil { | ||
| return *gpStatus, err | ||
| } | ||
| return *gpStatus, nil | ||
| } |
There was a problem hiding this comment.
better to:
return nil, err
and have CameraStatus be a pointer
| func GetISO(in int) int { | ||
| switch in { |
|
|
||
| func GetVidRes(in int) string { | ||
| switch in { |
There was a problem hiding this comment.
also needs more resolutions, 5k, 5k 4:3, etc...
|
|
||
| func GetWhiteBalance(in int) string { | ||
| switch in { |
There was a problem hiding this comment.
private.
Not sure if hardcoding these values is the way to go, especially when we have that stuff on /gp/gpControl manifest. Better to parse the manifest and build functions / maps from it
Initial Info support
Closes #83
Added initial support for info command.
Needs work to give error for other cameras
Type:
Camera:
Component:
Checklist before approval: