Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Wish from Charm as a boilerplate for SSH app #15

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LeoColomb
Copy link
Contributor

@LeoColomb LeoColomb commented Apr 12, 2024

For my next contribution, I'm considering refactoring some parts of the SSH server/app.
The main goals:

  • Reduce the size of IngreSsh SSH server/app code base, to ease the maintenance as much as possible.
  • Embrace best practices & best UX for this kind of app, i.e., lower surface for any opinionated tweaks.

Why Wish?

  • Current app already uses most of the Charm modules that Wish depends on;
  • Wish is the perfect wrapper for this kind of app;
  • The technical dept will delegate responsibility to Charm's implementation;
  • Wishlist app provides a reference on how to use it.

As it might be quite an effort, few checks before I actually start:

  • Does that sound interesting to you?
  • After all the noises and contributions I made these last weeks, should I slow down, or can I keep it up?

@Kooper
Copy link
Owner

Kooper commented Apr 12, 2024

@LeoColomb, I think we may go this direction.
I have no prior experience with Wish, however, your reasoning makes sense - if we're able to achieve a more compact implementation this will be fine. Streamlining UX and unlocking new features will also be great.

As for the development pace - it's up to you. I'm OK with reviewing changesets once in a day or two now 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants