Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12 support #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

1.12 support #18

wants to merge 1 commit into from

Conversation

R-T-B
Copy link
Member

@R-T-B R-T-B commented Jun 25, 2021

Add basic support for the new 1.12.0 date formatting.

Add basic support for the new 1.12.0 date formatting.
@@ -398,6 +398,11 @@ public virtual string PrintDateDeltaCompact(double time, bool includeTime, bool
return stringBuilder.ToStringAndRelease();
}

public virtual string PrintDateDeltaCompact(double time, bool includeTime, bool includeSeconds, bool useAbs, int uselessint)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @R-T-B , thanks for the PR

are you sure the int is actually useless?

Copy link
Member Author

@R-T-B R-T-B Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For our purpose? Yes. To squad? No idea. I have seen no side effects with my testers, however.

@linuxgurugamer
Copy link

@Sigma88 @R-T-B 's version has been in use with JNSQ for a few months now, and works well. Could you get this merged and released soon?

@Sigma88
Copy link
Collaborator

Sigma88 commented Aug 22, 2021

I am on vacation right now so I don't have the tools necessary to make a release.
if @R-T-B is happy with taking over this addon I am happy to give him the reins of kronometer

@R-T-B
Copy link
Member Author

R-T-B commented Aug 22, 2021

I've been stretched thin lately but given there is no more immediate threat of updates to KSP, I could probably manage.

If you want to do that, just let me know.

@Sigma88
Copy link
Collaborator

Sigma88 commented Aug 23, 2021

I have no time for ksp right now, so if you don't mind taking over kronometer you have my blessing.

otherwise it will be discontinued until I have more free time at my disposal

@linuxgurugamer
Copy link

Oh, ok. I wasn't planning on it, but will do so. As usual, will be happy to return it to you if/when you return

@linuxgurugamer
Copy link

I have a release ready, just waiting for @R-T-B to test it

@Sigma88
Copy link
Collaborator

Sigma88 commented Aug 23, 2021

@linuxgurugamer thanks for picking this up.

before I was refering to rtb when I said "if you dont mind taking over". however I am happy with either of you two taking over.

sorry I kind of disappeared from ksp, but rl took away most of my free time

@linuxgurugamer
Copy link

Oh, sorry I misunderstood. But I have a release ready, so as soon as he tests, I'll be able to release.
Hope all is well with you. Let me know if there is anything I can help with

@linuxgurugamer
Copy link

@Sigma88
I've released my version
Could you update the OP to say that the version for 1.12 is available here:
https://github.com/linuxgurugamer/Kronometer/releases/latest

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants