-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.12 support #18
base: master
Are you sure you want to change the base?
1.12 support #18
Conversation
Add basic support for the new 1.12.0 date formatting.
@@ -398,6 +398,11 @@ public virtual string PrintDateDeltaCompact(double time, bool includeTime, bool | |||
return stringBuilder.ToStringAndRelease(); | |||
} | |||
|
|||
public virtual string PrintDateDeltaCompact(double time, bool includeTime, bool includeSeconds, bool useAbs, int uselessint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @R-T-B , thanks for the PR
are you sure the int is actually useless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our purpose? Yes. To squad? No idea. I have seen no side effects with my testers, however.
I am on vacation right now so I don't have the tools necessary to make a release. |
I've been stretched thin lately but given there is no more immediate threat of updates to KSP, I could probably manage. If you want to do that, just let me know. |
I have no time for ksp right now, so if you don't mind taking over kronometer you have my blessing. otherwise it will be discontinued until I have more free time at my disposal |
Oh, ok. I wasn't planning on it, but will do so. As usual, will be happy to return it to you if/when you return |
I have a release ready, just waiting for @R-T-B to test it |
@linuxgurugamer thanks for picking this up. before I was refering to rtb when I said "if you dont mind taking over". however I am happy with either of you two taking over. sorry I kind of disappeared from ksp, but rl took away most of my free time |
Oh, sorry I misunderstood. But I have a release ready, so as soon as he tests, I'll be able to release. |
@Sigma88 Thanks |
Add basic support for the new 1.12.0 date formatting.