-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for invalid input #43
base: master
Are you sure you want to change the base?
Conversation
Oh, I haven't look at this in a while... Just a sec, I'll get it rebased and take a look at the requests |
Now that I've taken another look at this, after a long break, I'm not too sure about how good of an idea this is. As it doesn't enforce legal tag names, Crel can still crash when So should we do
And if an invalid tag name is given, should crel:
I'd also like to get your thoughts on what to do on empty (For the record, I do think 1806e47 and 9b45acf are good changes tho) |
Based on #46
null
andundefined
as children (1806e47)With this Crel shouldn't crash anymore, if it's accidentally fed garbage