Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - allow an allowed user to trigger on un-allowed user #347

Open
ezelkow1 opened this issue Oct 9, 2021 · 1 comment
Open

Comments

@ezelkow1
Copy link

ezelkow1 commented Oct 9, 2021

We are using the user restriction to restrict PR runs to only our org or known users. We also use the comment trigger to be able to retrigger CI runs. However for users not on the allowed list having an allowed user issue the comment trigger still wont trigger the CI since the PR creator is not in the allowed list.

So it would be good to have an option or way to allow any allowed user to be able to trigger a CI run via comments or any of the allowed methods instead of a blanket ban on a PR just because a user is not in the list

This sort of relates to the 'comment to add user to allow list' functionality that was removed, this would be a good second option to at least allow privileged users the ability to execute CI runs for unprivileged

@Sapr0
Copy link
Contributor

Sapr0 commented Dec 23, 2021

We have a similar requirement where an admin/manager can choose to approve a PR via a comment.
However the user in GITHUB_PR_TRIGGER_SENDER_AUTHOR is still the original PR owner.
We need an a new property that can be populated with the user who wrote the comment.
That way we can check if a privileged user can trigger the process.

Possible name choices for this new property are:

  • GITHUB_PR_COMMENT_USER
  • GITHUB_PR_COMMENT_SENDER
  • GITHUB_PR_COMMENT_AUTHOR

LE: Added 2 new properties, which are similar with the COMMIT and TRIGGER equivalents

  • GITHUB_PR_COMMENT_AUTHOR_NAME
  • GITHUB_PR_COMMENT_AUTHOR_EMAIL

KostyaSha pushed a commit that referenced this issue Dec 28, 2021
* Add two properties for comment author name and email

* Fix email typo

* Switch tests code using matchers

Co-authored-by: Bogdan Ailiesei <ailiesei@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants