-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMP Kotlin-to-Java direct actualization #391
Comments
I'm a little unclear whether // COMMON
expect class Foo {
fun bar()
class Quux {}
} @KotlinActual
public class Foo {
@KotlinActual // (1) needed?
public void bar() {...}
public void baz() {...}
@KotlinActual // (2) needed?
public static class Quux {}
} It would seem tedious to have to annotate (1) in particular, i.e., every method corresponding to a declaration in the expected class. |
Yes, both (1) and (2) will be needed.
I understand the concern. I agree that initially, it will be harder to commonize existing Java classes, but hopefully It's appealing to me that the annotation resembles |
The proposal makes no mention of Are there technical limitations to expressing those? Would mirroring the same class and static instance holder structure with the annotation on both work? |
@JakeWharton |
This issue is for discussion of the proposed Kotlin-to-Java direct actualization. The full text of the proposal is here.
PR: #392
The text was updated successfully, but these errors were encountered: