This repository has been archived by the owner on Jul 13, 2020. It is now read-only.
childrenRecursiveSequence: fix NoSuchElementException being thrown when hasNext() returned true #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a problem caused by ViewChildrenRecursiveSequence's iterator
next
andhasNext
both callinginitItemIterator
.After
hasNext
returnstrue
itemIterator
is notnull
, therefore the conditioniterator == null || (!iterator.hasNext() && seqs.isNotEmpty())
in
initItemIterator
is equivalent to!iterator.hasNext() && seqs.isNotEmpty()
which is
false
becauseiterator.hasNext()
istrue
.So
initItemIterator
innext()
setsitemIterator
tonull
, causing aNoSuchElementException
to be thrown.A test for the
childrenSequence()
andchildrenRecursiveSequence()
functions has been included.