small fix for two failing tests in #713, where in implodeImpl a tempo…

…rary column was created with nulls in a FrameColumn
Kotlin · Jul 30, 2024 · 3037a97 · 3037a97
1 parent cd3747f
commit 3037a97
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/implode.kt b/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/implode.kt
@@ -30,8 +30,14 @@ internal fun <T, C> DataFrame<T>.implodeImpl(dropNA: Boolean = false, columns: C
                     first = false
                     value
                 } else {
-                    null
+                    // these rows will not be taken into account,
+                    // but we cannot leave them empty, as `map` creates a full column
+                    when (column.kind()) {
+                        ColumnKind.Value -> emptyList<Any?>()
+                        ColumnKind.Group -> DataFrame.empty()
+                        ColumnKind.Frame -> emptyList<AnyFrame>()
+                    }
                 }
             }
-        }[0..0]
+        }[0..0] // takes only the first row
     }.concat()