Skip to content

textColor does not work for number colums #251

@pacher

Description

@pacher

To reproduce:

df.format().with { textColor(green) }

expected all cells are green
actual number columns are not

What is happening:

Resulting td html elements do have correct style <td style="color:#ff0000">.
But for number columns a nested <span class="numbers"> element is rendered inside td (source)
and for css class numbers there is a css rule (source) which overrides text color set by format operator in outer td style.

If I remove this rule, I don't see a difference, so I am disabling this css rule for a quick-fix with additional css

    table.dataframe .formatted .numbers {
        color: unset;
    } 

but there must be a reason why this rule exists, so something somewhere might break if we just delete it. Would be really great if somebody more versed in dataframe css could have a look at this.

It's also possible that there could be other issues like this where css overrides explicit formatting with format operator.

Or was it intentional? And text color was meant really only for text as opposed to numbers? Shall we add numberColor to FormattingDSL in this case?

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions