Skip to content

unfold / toDataFrame behavior for Maps #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jolanrensen opened this issue Sep 30, 2024 · 1 comment · Fixed by #1097
Closed

unfold / toDataFrame behavior for Maps #896

Jolanrensen opened this issue Sep 30, 2024 · 1 comment · Fixed by #1097
Assignees
Labels
enhancement New feature or request

Comments

@Jolanrensen
Copy link
Collaborator

Could we make it so that kotlin.Map<String, T> is recognized and unfolded to a KeyValueProperty/NamedValuePair by default?

Currently, since toDataFrame { properties() } is the default, they are unfolded like:
image

which is not very helpful.

@Jolanrensen Jolanrensen added the enhancement New feature or request label Sep 30, 2024
@Jolanrensen Jolanrensen changed the title Map unfold/toDataFrame behavior unfold / toDataFrame behavior for Maps Sep 30, 2024
@zaleslaw zaleslaw added this to the Backlog milestone Oct 4, 2024
@zaleslaw zaleslaw modified the milestones: Backlog, 0.16 Feb 27, 2025
@Jolanrensen
Copy link
Collaborator Author

@AndreiKingsley
Let's make Map a value type instead of unpacking it. It becomes very difficult to go from List -> DataFrame -> List if we start doing something special for certain types like Maps.

We can still create a List<Map<String, T>>.toDataFrame() and Map<String, T>.toDataRow() overload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants