Map unfold #1097
Merged
Map unfold #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
reviewed
Mar 14, 2025
| @@ -69,6 +76,7 @@ internal val KClass<*>.isValueType: Boolean | |||
| this in valueTypes || | |||
| this.isSubclassOf(Number::class) || | |||
| this.isSubclassOf(Enum::class) || | |||
| this.isSubclassOf(Map::class) || | |||
There was a problem hiding this comment.
This is not consistent with plugin - here it's all subclasses, in plugin only Map and MutableMap specifically. Which one should it be?
There was a problem hiding this comment.
I would do it like the plugin. There are many classes that have List or Map as supertype but they should probably be treated like a normal class.
There was a problem hiding this comment.
Only Map and MutableMap. Fixed.
Jolanrensen
approved these changes
Mar 14, 2025
| @@ -58,6 +58,13 @@ private val valueTypes = setOf( | |||
| kotlinx.datetime.DateTimeUnit::class, | |||
| ) | |||
|
|
|||
| /** | |||
| * Check | |||
| ) | ||
|
|
||
| /** | ||
| * Check | ||
| */ |
There was a problem hiding this comment.
very clean solution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #896.
Now
Mapis treated like value class and not unfolded. Also fix unfolding behavior inunfold(now it's the same as intoDataFrame())