remove docs and deprecating df - cols
#1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/remove.kt
Jolanrensen
requested changes
Jan 27, 2025
| */ | ||
| internal interface Remove | ||
|
|
||
| /** {@set [SelectingColumns.OperationArg] [remove][remove]} */ |
There was a problem hiding this comment.
OperationArg does not exist. OPERATION does
| @@ -79,6 +79,9 @@ internal const val IS_URL_IMPORT = "org.jetbrains.kotlinx.dataframe.io.isUrl" | |||
|
|
|||
| private const val MESSAGE_0_17 = "Will be ERROR in 0.17." | |||
|
|
|||
| internal const val MINUS = "This minus overload will be removed in favor of `remove`. $MESSAGE_0_17" | |||
There was a problem hiding this comment.
to speed up the cleanup, let's actually make this ERROR in 0.16 already :)
| * | ||
| * See [Selecting Columns][Select.SelectSelectingOptions]. | ||
| * | ||
| * For more information: {@include [DocumentationUrls.Remove]} |
There was a problem hiding this comment.
We will probably move this to a @see tag later, but for now it looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove#819