Add some AccessApiOverload annotations #1031
Conversation
koperagen
force-pushed
the
acess-api-overload-1
branch
from
5d55adf to
3769ca2
Compare
| @@ -34,6 +34,7 @@ public interface SortDsl<out T> : ColumnsSelectionDsl<T> { | |||
|
|
|||
| public fun String.desc(): SingleColumn<Comparable<*>?> = invoke<Comparable<*>>().desc() | |||
|
|
|||
| @AccessApiOverload | |||
There was a problem hiding this comment.
are we also deprecating extension functions on KProperty?
There was a problem hiding this comment.
At least those from different column selection DSLs
|
Do you actually also run a test somewhere to check whether the minimized dataframe-core still compiles? It could be that we use our public api somewhere internally |
| @@ -28,13 +28,16 @@ public interface DataRow<out T> { | |||
|
|
|||
| public operator fun <R> get(expression: RowExpression<T, R>): R = expression(this, this) | |||
|
|
|||
| @AccessApiOverload | |||
| public operator fun <R> get(column: ColumnReference<R>): R | |||
There was a problem hiding this comment.
hmm maybe not exclude these ones yet? Let's say we have a DataRow<Any>, calling row["name"] provides no way of specifying the type. You can however do row[column<String>("name")] to get the type. (potentially even row["name"<String>()]) It would also suffice if we could get a typed row.get<String>("name") function I believe.
There was a problem hiding this comment.
we have row.getValue<String>("name")
There was a problem hiding this comment.
ah didn't notice it, as it was an extension function, great :)
We use it, but it still compiles |
oh right, you only change visibility, very cool :) |
No description provided.