DynamicDataFrameBuilder improvements #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
approved these changes
Mar 4, 2025
| * A builder class for dynamically constructing a DataFrame with provided columns. | ||
| * Allows adding columns manually while automatically handling duplicate column names by assigning unique names. | ||
| * | ||
| * @property checkDuplicateValues Whether to check for duplicate column (with identical names and values) |
There was a problem hiding this comment.
not clear what "to check" means, at least not what it does. What actually happens when I set it to false or true?
There was a problem hiding this comment.
ah I see you explain it below, best to have it here too
| public fun get(column: String): AnyCol? = cols[column] | ||
|
|
||
| /** | ||
| * Converts the current `DynamicDataFrameBuilder` instance into a `DataFrame`. |
There was a problem hiding this comment.
using [] works better than just backticks, it's clickable and refactor safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #715.