Skip to content

Prepare plugin to be moved to Kotlin repository #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

koperagen
Copy link
Collaborator

  1. Removing all I/O, Import annotation
  2. Publishing fatjar minimized to only whatever is needed for compiler plugin to work, as much as possible. New artifact will be org.jetbrains.kotlinx:dataframe-core-all (it's a variant of core)
  3. Switching to -Xjvm-default=all
    Now default methods in interfaces will be generated as java default methods in bytecode. This change removes 4 mb of duplicated code on DefaultImpls static classes in our core jar. Massive change in cope.api comes from this

Now default methods in interfaces will be generated as java default methods in bytecode. This change removes 4 mb of duplicated code on DefaultImpls static classes in our core jar
@koperagen koperagen added infrastructure GitHub actions, Gradle Scripts, Writerside, etc. Compiler plugin Anything related to the DataFrame Compiler Plugin labels Mar 4, 2025
@koperagen koperagen added this to the 0.16 milestone Mar 4, 2025
@koperagen koperagen self-assigned this Mar 4, 2025
@Jolanrensen Jolanrensen self-requested a review March 4, 2025 16:47
Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! :) Could I suggest you add a line to https://github.com/Kotlin/dataframe/blob/master/CONTRIBUTING.md#building telling about how to run a shadow build and what that does? Then I think it's complete :)

@koperagen
Copy link
Collaborator Author

koperagen commented Mar 4, 2025

Great job! :) Could I suggest you add a line to https://github.com/Kotlin/dataframe/blob/master/CONTRIBUTING.md#building telling about how to run a shadow build and what that does? Then I think it's complete :)

It's nothing special, think of it as "-sources.jar", "-javadoc.jar". It's published along with core by publishToMavenLocal or publish

@koperagen koperagen merged commit 93151c0 into master Mar 5, 2025
6 of 7 checks passed
@Jolanrensen
Copy link
Collaborator

Great job! :) Could I suggest you add a line to https://github.com/Kotlin/dataframe/blob/master/CONTRIBUTING.md#building telling about how to run a shadow build and what that does? Then I think it's complete :)

It's nothing special, think of it as "-sources.jar", "-javadoc.jar". It's published along with core by publishToMavenLocal or publish

then a small comment next to the shadow jar configuration could also do. Especially since the compiler plugin will be moved out of the repo, it's important to mark things relevant to the compiler plugin so that we don't forget that it's relevant in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler plugin Anything related to the DataFrame Compiler Plugin infrastructure GitHub actions, Gradle Scripts, Writerside, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants