Skip to content

Removed digitize functionality #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Removed digitize functionality #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions core/api/core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,17 +1939,6 @@ public final class org/jetbrains/kotlinx/dataframe/api/DescribeKt {
public static final fun describe (Lorg/jetbrains/kotlinx/dataframe/DataFrame;[Lorg/jetbrains/kotlinx/dataframe/columns/ColumnReference;)Lorg/jetbrains/kotlinx/dataframe/DataFrame;
}

public final class org/jetbrains/kotlinx/dataframe/api/DigitizeKt {
public static final fun digitize (Lorg/jetbrains/kotlinx/dataframe/DataColumn;Ljava/util/List;Lkotlin/reflect/KClass;Z)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
public static final fun digitize (Lorg/jetbrains/kotlinx/dataframe/DataColumn;Ljava/util/List;Z)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
public static final fun digitize (Lorg/jetbrains/kotlinx/dataframe/DataColumn;[IZ)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
public static final fun digitize (Lorg/jetbrains/kotlinx/dataframe/DataColumn;[Ljava/lang/Comparable;Z)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
public static synthetic fun digitize$default (Lorg/jetbrains/kotlinx/dataframe/DataColumn;Ljava/util/List;Lkotlin/reflect/KClass;ZILjava/lang/Object;)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
public static synthetic fun digitize$default (Lorg/jetbrains/kotlinx/dataframe/DataColumn;Ljava/util/List;ZILjava/lang/Object;)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
public static synthetic fun digitize$default (Lorg/jetbrains/kotlinx/dataframe/DataColumn;[IZILjava/lang/Object;)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
public static synthetic fun digitize$default (Lorg/jetbrains/kotlinx/dataframe/DataColumn;[Ljava/lang/Comparable;ZILjava/lang/Object;)Lorg/jetbrains/kotlinx/dataframe/DataColumn;
}

public abstract interface class org/jetbrains/kotlinx/dataframe/api/DistinctColumnsSelectionDsl {
public fun distinct (Lorg/jetbrains/kotlinx/dataframe/columns/ColumnSet;)Lorg/jetbrains/kotlinx/dataframe/columns/ColumnSet;
}
Expand Down
39 changes: 0 additions & 39 deletions core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/digitize.kt
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/testSets/person/DataFrameTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import org.jetbrains.kotlinx.dataframe.api.countDistinct
import org.jetbrains.kotlinx.dataframe.api.dataFrameOf
import org.jetbrains.kotlinx.dataframe.api.default
import org.jetbrains.kotlinx.dataframe.api.describe
import org.jetbrains.kotlinx.dataframe.api.digitize
import org.jetbrains.kotlinx.dataframe.api.distinct
import org.jetbrains.kotlinx.dataframe.api.distinctBy
import org.jetbrains.kotlinx.dataframe.api.div
Expand Down Expand Up @@ -1533,29 +1532,6 @@ class DataFrameTests : BaseTest() {
parsed shouldBe typed
}

@Test
fun digitize() {
val a = 20
val b = 40
val expected = typed.age.toList().map {
when {
it < a -> 0
it < b -> 1
else -> 2
}
}
typed.age.digitize(a, b).toList() shouldBe expected

val expectedRight = typed.age.toList().map {
when {
it <= a -> 0
it <= b -> 1
else -> 2
}
}
typed.age.digitize(a, b, right = true).toList() shouldBe expectedRight
}

@Test
fun corr() {
val fixed = typed.fillNulls { weight }.with { 60 }
Expand Down