[Compiler plugin] join operations support #1139
Conversation
koperagen
added
the
Compiler plugin
koperagen
changed the title
koperagen
force-pushed
the
compiler-plugin-join-support
branch
2 times, most recently
from
2a17323 to
bccd01e
Compare
|
|
||
| internal data class ColumnMatchApproximation(val left: ColumnsResolver, val right: ColumnsResolver) | ||
| internal data class ColumnMatchApproximation( |
There was a problem hiding this comment.
Could you give me a hint, what does Approximation mean. I see a lot in naming, but could not understand the idea
There was a problem hiding this comment.
In library we have ColumnMatch, and operations work with this class. We implement the same operation in compiler plugin, but we cannot cover 100% of usages, for example if some variable is used instead of constant, and we cannot refer to DataFrame - instead we have more limited PluginDataFrameSchema, etc. So it wouldn't be fair to just name it "ColumnMatch". Approximation indicates that it's "compile-time ColumnMatch". Something like this
| } | ||
|
|
||
| internal class ColumnListImpl<C>(override val columns: List<ColumnsResolver<C>>) : | ||
| ColumnSet<C>, |
There was a problem hiding this comment.
wow, formatting looks weird to me
There was a problem hiding this comment.
Unfortunately this is the only way the linter allows it
koperagen
force-pushed
the
compiler-plugin-join-support
branch
from
bccd01e to
9440640
Compare
In first commit i adapted
ColumnMatchandColumnListto embed them into compiler plugin column resolving mechanismNew util functions designed to make sure all column names generated by compiler plugin in join are exactly as in runtime, and make sure there are no missing columns. They can however sometimes have nullability where runtime narrows the type to non-nullable