-
Notifications
You must be signed in to change notification settings - Fork 73
Json module extraction #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Json module extraction #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3be1629
to
993e6d3
Compare
b336d35
to
73e6f79
Compare
41d02be
to
a7c5d2b
Compare
@koperagen @zaleslaw @AndrewKis As discovered by @ileasile we'd better migrate all jupyter dependencies to gradle.build.kts instead of the jupyter integration. We can see that readJsonStr now breaks for notebooks. |
fb330f0
to
c5821dd
Compare
@ileasile Thanks ❤️ |
AndrewKis
reviewed
Apr 28, 2025
dataframe-excel/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/xlsx.kt
Outdated
Show resolved
Hide resolved
AndrewKis
reviewed
Apr 28, 2025
dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/io/writeDelim.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
dataframe-csv, and dataframe-excel allow writing DataFrame/DataRow as json. I rewrote this via a reflection call for now, prompting the user to add the dataframe-json package if they need this functionality. This is a bit hacky and might need a better solution. I was thinking of adding atoStr
function in theSupportedDataFrameFormat
service. That way they can checksupportedFormats
for aSupportedDataFrameFormat
that accepts thejson
extension and call that generic one.SupportedDataFrameFormat
for parsing String -> AnyRow/AnyFrame or by allowing the parser to become pluggable itself (Allow custom Parsers #962). Solved with reflection for now