Skip to content

Simplifies some dependencies, especially jupyter #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Simplifies some dependencies, especially jupyter #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5269750
simplified jupyter dependencies
Jolanrensen Apr 29, 2025
a44f749
simplified other dependencies
Jolanrensen Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ configurations {

dependencies {
api(projects.core)

// expose all optional IO dependencies by default
api(projects.dataframeArrow)
api(projects.dataframeExcel)
api(projects.dataframeJdbc)
Expand Down
1 change: 0 additions & 1 deletion dataframe-arrow/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ dependencies {
implementation(libs.kotlin.reflect)
implementation(libs.kotlin.datetimeJvm)

testApi(projects.core)
testImplementation(libs.junit)
testImplementation(libs.kotestAssertions) {
exclude("org.jetbrains.kotlin", "kotlin-stdlib-jdk8")
Expand Down
1 change: 0 additions & 1 deletion dataframe-csv/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ dependencies {
implementation(libs.kotlinLogging)
implementation(libs.kotlin.reflect)

testApi(projects.core)
testImplementation(libs.kotlinx.benchmark.runtime)
testImplementation(libs.junit)
testImplementation(libs.sl4jsimple)
Expand Down
7 changes: 1 addition & 6 deletions dataframe-jupyter/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,10 @@ repositories {
}

dependencies {
api(projects.core)
api(projects.dataframeJson)
api(projects.dataframe)

testImplementation(libs.junit)
testImplementation(libs.serialization.json)
testImplementation(projects.dataframeArrow)
testImplementation(projects.dataframeCsv)
testImplementation(projects.dataframeExcel)
testImplementation(projects.dataframeJdbc)
// experimental
testImplementation(projects.dataframeOpenapiGenerator)
testImplementation(projects.dataframeOpenapi)
Expand Down
6 changes: 0 additions & 6 deletions dataframe-jupyter/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/Integration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,6 @@ internal class Integration(private val notebook: Notebook, private val options:
"org.jetbrains.kotlinx:dataframe-openapi-generator:$version",
)
}
dependencies(
"org.jetbrains.kotlinx:dataframe-csv:$version",
"org.jetbrains.kotlinx:dataframe-excel:$version",
"org.jetbrains.kotlinx:dataframe-jdbc:$version",
"org.jetbrains.kotlinx:dataframe-arrow:$version",
)
}

try {
Expand Down
7 changes: 1 addition & 6 deletions plugins/dataframe-gradle-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,7 @@ group = "org.jetbrains.kotlinx.dataframe"

dependencies {
api(libs.kotlin.reflect)
implementation(projects.core)
implementation(projects.dataframeArrow)
implementation(projects.dataframeExcel)
implementation(projects.dataframeCsv)
implementation(projects.dataframeJdbc)
implementation(projects.dataframeJson)
implementation(projects.dataframe)
// experimental
implementation(projects.dataframeOpenapiGenerator)

Expand Down
7 changes: 1 addition & 6 deletions plugins/symbol-processor/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,7 @@ repositories {
group = "org.jetbrains.kotlinx.dataframe"

dependencies {
implementation(projects.core)
implementation(projects.dataframeArrow)
implementation(projects.dataframeExcel)
implementation(projects.dataframeCsv)
implementation(projects.dataframeJdbc)
implementation(projects.dataframeJson)
implementation(projects.dataframe)
// experimental
implementation(projects.dataframeOpenapiGenerator)

Expand Down
6 changes: 1 addition & 5 deletions tests/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ repositories {
}

dependencies {
implementation(projects.core)
implementation(projects.dataframeExcel)
implementation(projects.dataframeCsv)
implementation(projects.dataframeJdbc)
implementation(projects.dataframeArrow)
implementation(projects.dataframe)
testImplementation(libs.junit)
testImplementation(libs.kotestAssertions) {
exclude("org.jetbrains.kotlin", "kotlin-stdlib-jdk8")
Expand Down