Deprecate @AccessApiOverload functions
#1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaleslaw
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the design goals of the library is typed access to columns.
That's why all operations that have "column" parameters used to have 4 overloads: String, ColumnReference, KProperties, and either DataRowExpression or ColumnSelector for generated extension properties. However, with compiler plugin reaching stable state, generated extension properties will appear in many new scenarios when you'd normally want to use column reference or kproperty. That's why we want to reconsider this design and simplify public API, moving most typed access to extension properties and String API as fallback mechanism whenever data frame schema cannot be evaluated at compile time.