-
Notifications
You must be signed in to change notification settings - Fork 73
Rework of dfs functions to recursively (changing return type of recurse-able functions) #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5e014f4
ground work for recursively()
Jolanrensen dac8c17
erasing type of transform functions
Jolanrensen 6ae692d
transform: (ColumnSet<*>) -> ColumnSet<*>
Jolanrensen d1a84a0
SingleColumn<*> in ColumnSelectionDsl. reworked ColumnSelectionDsl tests
Jolanrensen 0e57b94
Merge branch 'master' into dfs-rename2
Jolanrensen 8b0b8a3
Merge branch 'master' into dfs-rename2
Jolanrensen e9dfab9
poc implemented, needs more tests
Jolanrensen 8fffbd1
fixed duplicate columns, needs more tests
Jolanrensen 25d4821
seems to be working! In the process of converting dfs usage to recurs…
Jolanrensen d1f584d
converted most if not all dfs usage to recursively
Jolanrensen 149e96f
docs for cols and all
Jolanrensen da89e93
first {}.recursively now seems to work. Why, I'm not sure. Needs more…
Jolanrensen 2d08793
getAt
Jolanrensen e3a115b
3rd attempt, now with different return-type, similar to the first dfs…
Jolanrensen 2dddcc0
children
Jolanrensen a47f67e
TransformableColumnSet and TransformableSingleColumn are now generali…
Jolanrensen 4bf8219
dfs -> allChildren
Jolanrensen efb8a04
Merge branch 'master' into dfs-rename3
Jolanrensen f94b252
adding allRecursively again, docs and cleaning
Jolanrensen 7c41875
removed ColumnPath overloads, fixed groups, added docs for allRec and…
Jolanrensen 8c16478
linting
Jolanrensen d79ed97
updated korro correctly
Jolanrensen 52b42ca
Merge branch 'master' into dfs-rename3
Jolanrensen f49f0cd
merged with master and updated docs to include allRecursively
Jolanrensen 79e7652
Merge branch 'master' into dfs-rename3
Jolanrensen 29975f5
updating after first round of reviews
Jolanrensen b4484f5
made renameToCamelCase clearer
Jolanrensen 06ccc7b
removing includeGroups param from recursively
Jolanrensen 95818f5
Merge branch 'master' into dfs-rename3
Jolanrensen 3aa7c0d
updating with korro
Jolanrensen b42cc5d
added auto add-to-git for copySamplesOutputs task, reran korro
Jolanrensen b085905
fixed korro deleting snippets files at a rerun
Jolanrensen d21934b
removed allRecursively and boolean arguments for recursively
Jolanrensen 9f40e89
Merge branch 'master' into dfs-rename3
Jolanrensen 5bf8463
Merge branch 'master' into dfs-rename3
Jolanrensen 9fdd5e3
updated from master
Jolanrensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.