Add option to prevent Gradle plugin from adding dependency on KSP #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's keep this somewhat internal for a while. I'll come up with good explanation for setup page later. For now i'd like to merge it without docs and update our own project to use it to simplify publishing process. |
koperagen
force-pushed
the
update-ksp-1921
branch
from
ab6a621 to
5e937ee
Compare
We add plugin automatically for better onboarding experience, but it makes project depend on some specific KSP version. KSP complains when people use it with different version of compiler: ksp-1.9.0-1.0.12 is too old for kotlin-1.9.21. Please upgrade ksp or downgrade kotlin-gradle-plugin to 1.9.0. In dataframe project itself we always need to update Kotlin version in two steps. With this change (and one more PR later) it won't be necessary anymore Still, it's ok to use preprocessor built for 1.9.0 with KSP 1.9.21. That's why we need an option for people to decide version of KSP they need in their project. People will be able to use our preprocessor built for older versions of KSP API most of the time without problems thanks to backward compatibility
koperagen
force-pushed
the
update-ksp-1921
branch
from
5e937ee to
e15cb54
Compare
Jolanrensen
approved these changes
Jan 25, 2024
zaleslaw
reviewed
Jan 26, 2024
| } | ||
|
|
||
| fun List<String>.joinToCamelCaseString(): String { | ||
| return joinToString(separator = "") { it.capitalize() } | ||
| return joinToString(separator = "") { s -> s.replaceFirstChar { if (it.isLowerCase()) it.titlecase(Locale.getDefault()) else it.toString() } } |
There was a problem hiding this comment.
Sorry, changes in the behaviour is not clear for me here. Is it related to the KSP update, isn't it?
There was a problem hiding this comment.
capitalize was deprecated some time ago. I come across the warning and decided to fix it
zaleslaw
approved these changes
Jan 26, 2024
|
One problem I found: This makes it so that the processor doesn't work at all. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add plugin automatically for better onboarding experience, but it makes project depend on some specific KSP version. KSP complains when people use it with different version of compiler:
ksp-1.9.0-1.0.12 is too old for kotlin-1.9.21. Please upgrade ksp or downgrade kotlin-gradle-plugin to 1.9.0.Still, it's ok to use preprocessor built for 1.9.0 with KSP 1.9.21. That's why we need an option for people to decide version of KSP they need in their project.
People will be able to use our preprocessor built for older versions of KSP API most of the time without problems thanks to backward compatibility
In dataframe project itself we always need to update Kotlin version in two steps. With this change (and one more PR later) it won't be necessary anymore