apply ksp to multiplatform configs in multiplatform modules #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks like you improved my old PR #592 :) thanks! I'll run the tests and check if it can be merged |
Jolanrensen
reviewed
Apr 8, 2024
| when { | ||
| target.plugins.hasPlugin("org.jetbrains.kotlin.jvm") -> false | ||
| target.plugins.hasPlugin("org.jetbrains.kotlin.multiplatform") -> true | ||
| else -> throw Exception("Kotlin plugin must be applied first so we know whether to use multiplatform configurations or not") |
Collaborator
There was a problem hiding this comment.
Actually, this exception might be dangerous, since we don't know all possible configurations users might have. We should default to false probably. Fixing it in #655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645