Skip to content

This fixes Nothing #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2024
Merged

This fixes Nothing #795

merged 3 commits into from
Jul 31, 2024

Conversation

@Jolanrensen
Copy link
Collaborator

@Jolanrensen Jolanrensen commented Jul 29, 2024

Fixes #748

  • mean() and std() of nothing now gives NaN, making sure describe() gives a result
  • describe(), std(), and mean() now render types better

Fixes #794

  • The common type for no classes is now defined as Nothing
  • This fixes inference of empty columns

@Jolanrensen Jolanrensen changed the title Nothing fixes This fixes Nothing Jul 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024

Generated sources will be updated after merging this PR.
Please inspect the changes in here.

@Jolanrensen Jolanrensen merged commit 7ff578a into master Jul 31, 2024
@Jolanrensen Jolanrensen deleted the number-fixes branch July 31, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaleslaw zaleslaw zaleslaw approved these changes

@koperagen koperagen Awaiting requested review from koperagen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataFrame with empty column infers type Any instead of Nothing DataColumn<Nothing>.isNumber() gives true

3 participants

@Jolanrensen @zaleslaw