-
Notifications
You must be signed in to change notification settings - Fork 72
Build config and Debug mode #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,14 @@ | ||
package org.jetbrains.kotlinx.dataframe.jupyter | ||
|
||
import org.jetbrains.kotlinx.dataframe.BuildConfig | ||
import org.jetbrains.kotlinx.dataframe.io.DisplayConfiguration | ||
|
||
public class JupyterConfiguration { | ||
public val display: DisplayConfiguration = DisplayConfiguration() | ||
|
||
/** Version of the library. */ | ||
public val version: String = BuildConfig.VERSION | ||
|
||
/** DSL accessor. */ | ||
public operator fun invoke(block: JupyterConfiguration.() -> Unit): JupyterConfiguration = apply(block) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,8 @@ org.gradle.jvmargs=-Xmx4G | |
# This makes it mandatory to explicitly apply your own version of the | ||
# KSP plugin in the modules that use it. | ||
kotlin.dataframe.add.ksp=false | ||
|
||
# Enables debug mode for dataframe. | ||
# This can make certain tests run that should not be run in production. | ||
# It can also be turned on from the command line with `-Pkotlin.dataframe.debug=true` | ||
kotlin.dataframe.debug=false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does it mean, that we could add more modes, with different names, it's not a strongly-defined schema? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. indeed, just an argument I came up with. Similar to the add.ksp argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It checks all values, right? Is it worth to check random 10-20 numbers from the column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we only check a handful of values there's a chance we won't catch the outlier and get flaky tests.