Empty csv fix #835
Empty csv fix #835
Conversation
| file = File.createTempFile("empty", "csv"), | ||
| header = listOf("a", "b", "c"), | ||
| ) | ||
| emptyCsvFileManualHeader shouldBe dataFrameOf("a", "b", "c").fill(0) { "" } |
There was a problem hiding this comment.
ah, wait, it's not zeros but 0 rows of empty strings?
There was a problem hiding this comment.
emptyCsvFileManualHeader["a"].type() shouldBe typeOf<String>()
emptyCsvFileManualHeader["a"].isEmpty() shouldBe true
There was a problem hiding this comment.
yes, this generates a DF with 3 named empty String columns
There was a problem hiding this comment.
I could also write something like dataFrameOf("a", "b", "c") { emptyList<String>() } or plenty of other variants :) not sure which is the clearest
There was a problem hiding this comment.
i'd prefer checks like above, because it takes time to imagine result of df constructor rather than see expected assertions
Jolanrensen
force-pushed
the
empty-csv-fix
branch
from
191f9f4 to
e277105
Compare
|
Please make a rebase and squash fixup before merge |
Jolanrensen
force-pushed
the
empty-csv-fix
branch
from
491eed7 to
d61769f
Compare
Jolanrensen
force-pushed
the
empty-csv-fix
branch
from
4d785f6 to
6f93a47
Compare
|
Generated sources will be updated after merging this PR. |
|
Thank you! Don't forget the milestone and other things |
they are already on the issue, as @zaleslaw recommended :) |
Fixes #834
See test for expected behavior