Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially inline AnyFrame typealias in return type position #888

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

koperagen
Copy link
Collaborator

@koperagen koperagen commented Sep 26, 2024

I noticed that completion pop-up still shows that AnyFrame = DataFrame<*> and it makes it look cluttered
It makes me want to remove all such type aliases :c But, we can start from dataFrameOf

Before:
image

Looks even worse on a narrow screen:
image

After:
image

image

@koperagen koperagen self-assigned this Sep 26, 2024
@koperagen koperagen added this to the 0.15.0 milestone Sep 26, 2024
I noticed that completion pop-up still shows that AnyFrame = DataFrame<*> and it makes it look cluttered
Copy link
Contributor

Generated sources will be updated after merging this PR.
Please inspect the changes in here.

@Jolanrensen
Copy link
Collaborator

Looks better indeed :) I do see the same behavior for argument types defined with type aliases in your screenshot. Should we keep those? or also replace them

@koperagen
Copy link
Collaborator Author

Looks better indeed :) I do see the same behavior for argument types defined with type aliases in your screenshot. Should we keep those? or also replace them

let's make an issue and merge this part

@koperagen koperagen merged commit ab99935 into master Oct 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants