[Compiler plugin] Generate ColumnName annotations on frontend for all names that contain illegal characters #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
added
the
Compiler plugin
Jolanrensen
approved these changes
Oct 10, 2024
| import org.jetbrains.kotlinx.dataframe.api.* | ||
| import org.jetbrains.kotlinx.dataframe.io.* | ||
|
|
||
| fun box(): String { |
There was a problem hiding this comment.
this is just so you don't have to create this file every time you need to quickly test something? ;P
There was a problem hiding this comment.
Yes indeed :) You need to create a file and run generateTests, it will modify BlackBoxTestsGenerated and you'd also need to rollback it if it was only a temporary test. Very inconvenient :c
| val override: Boolean = false | ||
| ) | ||
|
|
||
| data class PropertyName(val identifier: Name, val columnNameAnnotation: FirAnnotation?) { |
There was a problem hiding this comment.
might deserve its own file? Makes it easier to find, especially since it's used very often
There was a problem hiding this comment.
Moved it under extensions.impl package and its own file
… names that contain illegal characters The way ColumnName is used: 1. When extracting schemas. PluginDataFrameSchema always contains actual names, and it's responsibility of the plugin to generate valid property name 2. When generating getter of extension property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now whenever column has name with illegal characters, they get replaced as in jupyter and ColumnName annotation is generated for the
The way ColumnName is used: