Skip to content

Specify slf4j-api instead of slf4j-simple. #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

erikogenvik
Copy link
Contributor

When used as a library in other components slf4j-api should be used, allowing the component to select the logging backend themselves (for example logback).

This fixes an issue where slf4j would complain that there were two competing logging backends in any application using this along with somehing like logback.

When used as a library in other components slf4j-api should be used,
 allowing the component to select the logging backend themselves
 (for example logback).
@Jolanrensen
Copy link
Collaborator

Thanks!
However, I see you added the new dependency only as testImplementation(), meaning it will only be used when running our dataframe tests, not when it's published as a library.

@erikogenvik
Copy link
Contributor Author

Sorry, I should have explained more thoroughly.
I changed so that the default dependency, that's part of what's exported, is now "slf4j-api". However, I noticed that you also had some tests, and I guessed that you do want logging output when running these tests.
Therefore I added a new "slf4j-simple" artifact (which is the one that contains a logging appender, and thus shouldn't be part of the distributed artifact) so that you'll get log output when running your tests.

@Jolanrensen
Copy link
Collaborator

Aaah, now I see :)

@Jolanrensen Jolanrensen requested a review from zaleslaw October 24, 2024 13:42
@Jolanrensen
Copy link
Collaborator

@zaleslaw could you also check everything works as expected? :)

@Jolanrensen Jolanrensen added the infrastructure GitHub actions, Gradle Scripts, Writerside, etc. label Oct 24, 2024
@Jolanrensen Jolanrensen linked an issue Oct 31, 2024 that may be closed by this pull request
@zaleslaw
Copy link
Collaborator

zaleslaw commented Nov 6, 2024

Thanks for contribution, @erikogenvik, I've checked the logic locally @Jolanrensen all seems correct

@zaleslaw zaleslaw merged commit 3c153fe into Kotlin:master Nov 6, 2024
2 checks passed
Jolanrensen pushed a commit that referenced this pull request Nov 8, 2024
When used as a library in other components slf4j-api should be used,
 allowing the component to select the logging backend themselves
 (for example logback).

(cherry picked from commit 3c153fe)
@Jolanrensen
Copy link
Collaborator

It's released along the hot-fix version 0.14.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure GitHub actions, Gradle Scripts, Writerside, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin Dataframe introduces a dependancy on org.slf4j.slf4j-simple
3 participants