[Compiler plugin] Support valueCounts #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
valueCounts
branch
from
6c30b4a to
cf5b4ec
Compare
It was supposed to be a source of truth to help choose correct arguments, but in reality it's more reliable to look at existing interpreters
koperagen
force-pushed
the
valueCounts
branch
from
cf5b4ec to
24ddca2
Compare
koperagen
added
the
Compiler plugin
zaleslaw
reviewed
Nov 19, 2024
| @@ -248,6 +249,7 @@ internal inline fun <reified T> String.load(): T { | |||
| "Update0" -> Update0() | |||
| "Aggregate" -> Aggregate() | |||
| "DataFrameOf3" -> DataFrameOf3() | |||
| "ValueCounts" -> ValueCounts() | |||
There was a problem hiding this comment.
https://kotlin.github.io/dataframe/valuecounts.html - very strange GROUP BY + DISTINCT
zaleslaw
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important part of this PR is first commit. Other two are rather trivial refactoring.
Inline all trivial delegates:
It was supposed to be a source of truth to help choose correct arguments, but in reality it's more reliable to look at existing interpreters