-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add df.properties()
function to improve visibility of generated API for typed column access
#957
Conversation
It will clash if you have |
3f3fafb
to
6f522c6
Compare
Hmm that means the API would have certain parts be available depending on the data. Functions are fine of course :) |
There's an important part: it's not available in selection dsl, so potential conflicts are limited to only
|
Yes, but we'd still have conflicts that don't need to be there. What's wrong with making a function instead? |
Because |
it's also an option to deprecate the old |
I need a pause for a week to play with it |
Alternative option: function named properties. example: |
I'd like properties more "https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.collections/to-properties.html" |
It's more like In DataFrame, however, we make a distinction between columns accessors, in the form of generated properties (
|
6f522c6
to
9126c05
Compare
df.columns
property to improve visibility of generated API for typed column accessdf.properties()
function to improve visibility of generated API for typed column access
9126c05
to
3cd4962
Compare
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataFrameGet.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful! Thanks!
… for typed column access
3cd4962
to
1e1d076
Compare
It's not always easy to tell if code generation in notebooks or compiler plugin worked as expected or find columns you're interested in without printing schema. With this change, people will have an option to overview generated column properties
In notebooks:
In compiler plugin: