Miscellaneous 0.15 fixes #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with new experimental module
koperagen
reviewed
Dec 5, 2024
| @@ -152,6 +156,15 @@ internal class Integration(private val notebook: Notebook, private val options: | |||
|
|
|||
| override fun Builder.onLoaded() { | |||
| if (version != null) { | |||
| if (enableExperimentalCsv?.toBoolean() == true) { | |||
| println("Enabling experimental CSV module: dataframe-csv") | |||
There was a problem hiding this comment.
Do you want to keep this println? It can't be disabled on user end
There was a problem hiding this comment.
I think it's good to have it, a good check for the user that the dataframe integration received the special command correctly and activated the dataframe-csv module.
It's also good to see it in the output of the notebook, to see something experimental is going on, like a small warning.
When the module is included by default I'll remove the message of course
koperagen
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all need to be cherry-picked to the 0.15.0 release branch