Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable publication of shadowRuntimeElements variant #2961

Merged

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Apr 16, 2023

Fixes the issue described in #2704 (comment)

Test

To test this I ran ./gradlew publishAllPublicationsToMavenProjectLocalRepository and searched for shadowRuntimeElements in the directory $rootDir/build/maven-project-local

On master branch there was a match. On the PR branch, there was no match.

@IgnatBeresnev IgnatBeresnev self-requested a review April 17, 2023 12:29
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing it!

…blish.gradle.kts

Co-authored-by: Ignat Beresnev <ignat@beresnev.me>
@IgnatBeresnev IgnatBeresnev merged commit 5e81202 into Kotlin:master Apr 17, 2023
@aSemy aSemy deleted the fix/disable_shadow_variant_publication branch April 17, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants