Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and document DisplaySourceSet #3105

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Refactor and document DisplaySourceSet #3105

merged 7 commits into from
Aug 14, 2023

Commits on Aug 4, 2023

  1. Deprecate internal API SelfRepresentingSingletonSet for removal as be… 

    …ing harmful and unimplement it in DisplaySourceSet

* Provide no automatic migration for DisplaySourceSet as there is no mechanisms for that. Manual migration is replacement of 'dss' to `setOf(dss)` where applicable
* Introduce a convenience-member DefaultRenderer.buildContentNode to avoid wrapping DSS into set manually

Fixes #2897
    @qwwdfsad
    qwwdfsad committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a6e8762 View commit details
    Browse the repository at this point in the history

  2. Document DisplaySourceSet & co

    @qwwdfsad
    qwwdfsad committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b349cc6 View commit details
    Browse the repository at this point in the history

  3. Replace Iterable<DisplaySourceSet>.sourceSetIDs with more straightfor… 

    …ward Iterable<DisplaySourceSet>.computeSourceSetIds()

* Refactor all the usages, save some allocations
* Start caching CompositeSourceSetID properties to avoid excessive allocations
    @qwwdfsad
    qwwdfsad committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    116d63d View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Update integration tests on the latest revision with Knit version whe… 

    …re the workaround is applied
    @qwwdfsad
    qwwdfsad committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9cc5bb9 View commit details
    Browse the repository at this point in the history

  2. ~update README

    @qwwdfsad
    qwwdfsad committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    82de700 View commit details
    Browse the repository at this point in the history

  3. Update DisplaySourceSet

    @qwwdfsad
    qwwdfsad committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3f9dea4 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. ~fix typo in the doc

    @qwwdfsad
    qwwdfsad committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d09cb88 View commit details
    Browse the repository at this point in the history