Restore fix #1599 #3143
Merged
Restore fix #1599 #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
force-pushed
the
restore-fix-1599
branch
from
ddd687e
to
67a4441
Compare
vmishenev
force-pushed
the
restore-fix-1599
branch
from
67a4441
to
08d8937
Compare
IgnatBeresnev
approved these changes
Sep 4, 2023
| // the main idea of this class is for each package to store roots which contains it to avoid excessive file system traversal | ||
| internal class JvmDependenciesIndexImpl(_roots: List<JavaRoot>) : JvmDependenciesIndex { | ||
| class JvmDependenciesIndexImpl(_roots: List<JavaRoot>) : JvmDependenciesIndex { | ||
| private val lock = ReentrantLock() |
There was a problem hiding this comment.
As a side note as it wasn't obvious for me until I asked Vadim about it: these classes were copy-pasted from the compiler (or, rather, the copy-paste was updated). So this change with adding ReentrantLock is coming from there:
I hope they tested it well and it won't introduce more performance regressions or other types of concurrency issues 🤞
IgnatBeresnev
added a commit
that referenced
this pull request
Sep 5, 2023
#3143 wasn't based on latest master, so the checks were green, but then the compilation failed due to explicit API mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3034 broke the fix #1599