-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub issues navigation for IDEA #3341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
I've checked out the branch, and I can see the changes, but I haven't done any additional testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, may be we can commit full |
I think It should be ok. I have no preferences about it. |
I also don't mind as long as there's no specific settings tailored for one person, but if it happens - it might be possible to add |
I've pushed |
Allows to click on issue/PR numbers in VCS history and be redirected to GitHub
Example:
Here on screenshot we can see Git window and 3 highlighted links:
#3333
and#3327
in the left panel +#3333
in the right panel. All of them are clickable and will redirect tohttps://github.com/Kotlin/dokka/pull/3333
orhttps://github.com/Kotlin/dokka/pull/3327
.Why do we need this?
This simplifies a lot following Git Blame, and so understanding of context on why one or another change were implemented (via PR comments or issue description).
In last couple of days, while investigating behaviour of CodeBlocks I've done a lot of copy-pasting of issue number to GitHub and I was tired of this :) So I've configured this for local development.
Later I've found, that it's possible to share this config via Git, like in kotlinx-coroutines: https://github.com/Kotlin/kotlinx.coroutines/blob/ecb5b3e1e3c94cf377b9b3d21a8ad455bc83f0d0/.idea/vcs.xml#L13.
PR in coroutines: Kotlin/kotlinx.coroutines#1920
And so here we are
P.S. If possible, please check, that after fetching this branch, changes are applied at your side. I have not added
vcs.xml
to.gitignore
for a reason: it can contain other settings, which we are not interested in