Remove configuration of transitive Dokka Engine dependencies #3794
Conversation
adam-enko
added
the
runner: Gradle plugin
| @@ -134,8 +134,9 @@ abstract class DokkaFormatPlugin( | |||
| // https://github.com/gradle/gradle/issues/27435) | |||
| dependenciesContainer.resolutionStrategy.eachDependency { | |||
There was a problem hiding this comment.
FYI: Using .eachDependency to specify version could lead to Gradle complain. I've fixed similar issue inside kotlin.git. Proposed solution is to use constraints with required (or some other level) version.
There was a problem hiding this comment.
Constraints require a list of all Dokka dependencies, and I don't think we have this.
I think improving this is on Gradle to fix gradle/gradle#15089
| * This value defaults to the current Dokka Gradle Plugin version, but can be overridden | ||
| * if you want to use a newer or older version of Dokka at runtime. | ||
| */ | ||
| val dokkaEngine: Property<String> |
There was a problem hiding this comment.
why not to move this on extension level and call just dokkaEngineVersion/engineVersion - similar to how KGP has compilerVersion when using build-tools-api?
Not sure we need Versions interface anymore
There was a problem hiding this comment.
Sure, I'll move it to the top level.
The reason I wanted to keep it nested inside a versions {} block was to avoid having too many options in the top level of dokka {}. I think keeping the lower-level options nested helps indicate that they are more complicated and advanced. Although I agree that a versions {} block seems pretty pointless without other versions, and it's unlikely that we'll be adding other versions.
tbh I think the top level dokka {} DSL is pretty disorganised and could do with a review, but it's hard to re-organise it without becoming too disconnected from the underlying Dokka configuration.
Anyway, we can revisit this later if needed.
dokka-runners/dokka-gradle-plugin/src/testFunctional/kotlin/DokkaPluginFunctionalTest.kt
Outdated
Show resolved
Hide resolved
...in/src/testFunctional/resources/KotlinDslAccessorsTest/root-project-v2-migration-helpers.txt
Outdated
Show resolved
Hide resolved
adam-enko
force-pushed
the
adam/feat/KT-70336/remove-transitive-dependency-config
branch
2 times, most recently
from
d9dd54b
to
ff1c959
Compare
…ies. DGP should only depend on Dokka Engine, and not prescriptively control what dependencies to declare. KT-71382
adam-enko
force-pushed
the
adam/feat/KT-70336/remove-transitive-dependency-config
branch
from
ff1c959
to
cc9ca6f
Compare
adam-enko
deleted the
adam/feat/KT-70336/remove-transitive-dependency-config
branch
Remove unnecessary configuration of Dokka Engine transitive dependencies.
DGP should only depend on Dokka Engine, and not prescriptively control what dependencies to declare.
KT-71382